Skip to content

ci: use pre-baked base images with rclone/shush pre-installed#6970

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:release-1.xfrom
wuhuizuo:ci/prebake-backup-manager-base-images
Jul 2, 2026
Merged

ci: use pre-baked base images with rclone/shush pre-installed#6970
ti-chi-bot[bot] merged 4 commits into
pingcap:release-1.xfrom
wuhuizuo:ci/prebake-backup-manager-base-images

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Switch backup-manager Dockerfiles to use pre-baked base images that have rclone and shush pre-installed, removing the direct GitHub downloads that cause rate-limiting failures in CI.

Changes

  • images/tidb-backup-manager/Dockerfile: Changed FROM to ghcr.io/pingcap-qe/ci/tidb-operator_backup-manager-base:v2026.6.28-7-g6f649337 and removed rclone/shush download steps
  • images/tidb-backup-manager/Dockerfile.e2e: Changed FROM to ghcr.io/pingcap-qe/ci/tidb-operator_e2e-base:v2026.6.28-7-g6f649337 and removed rclone/shush download steps

Testing

CI image build will no longer download rclone/shush from GitHub releases, avoiding rate-limit failures.

Risk

Low. The base images contain identical versions of rclone (v1.71.2) and shush (v1.5.5) as were previously downloaded at build time.

@ti-chi-bot ti-chi-bot Bot added the size/S label Jul 1, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.55%. Comparing base (a16b2e8) to head (9eb7220).
⚠️ Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6970      +/-   ##
==========================================
+ Coverage   57.19%   57.55%   +0.35%     
==========================================
  Files         259      262       +3     
  Lines       33233    38237    +5004     
==========================================
+ Hits        19008    22006    +2998     
- Misses      12291    14152    +1861     
- Partials     1934     2079     +145     
Flag Coverage Δ
unittest 57.55% <ø> (+0.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wuhuizuo wuhuizuo changed the base branch from master to release-1.x July 1, 2026 06:31
…ackup-manager-base-images

# Conflicts:
#	images/tidb-backup-manager/Dockerfile
#	images/tidb-backup-manager/Dockerfile.e2e
@ti-chi-bot ti-chi-bot Bot added size/M and removed size/S labels Jul 1, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kind-br 2d17cd5 link false /test pull-e2e-kind-br

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot

ti-chi-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-07-02 04:10:45.711762222 +0000 UTC m=+271787.412141635: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot Bot merged commit 74ac23b into pingcap:release-1.x Jul 2, 2026
14 of 15 checks passed
@wuhuizuo wuhuizuo deleted the ci/prebake-backup-manager-base-images branch July 2, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants